-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix instability in RBM #37
Merged
YifanCheng
merged 29 commits into
UW-Hydro:RBM_res_develop
from
YifanCheng:RBM_res_develop
May 7, 2018
Merged
Fix instability in RBM #37
YifanCheng
merged 29 commits into
UW-Hydro:RBM_res_develop
from
YifanCheng:RBM_res_develop
May 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed if loop in Systmm
…o RBM_res_develop
add some output sentence to check the output
based on numerical error to adjust the timestep to calculate stream temperature
this bug is resulted from reservoir storage calculation.
2) estimate how long it will take to reach equilibrium
This pull request was merged as this is a stable version of RBM-2L. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numerical instability was found in river temperature and reservoir temperature simulation results in RBM. In this PR, the numerical instability problem is fixed. Main changes made are concluded as follows: